Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
app/components/Terminal.tsx
Outdated
|
|
||
| window.addEventListener('resize', resize) | ||
|
|
||
| // Update terminal colors when the theme changes |
There was a problem hiding this comment.
Small thing but otherwise you're stuck with the alternate theme if you switch on this screen
| // Ensure the connecting skeleton shows for at least 1s so users see | ||
| // the connection is being established rather than a brief flash | ||
| const connectingAt = useRef(canConnect ? Date.now() : 0) | ||
| const MIN_CONNECTING_MS = 1000 |
There was a problem hiding this comment.
The flash looked a little broken if it came through quickly
| ws.current?.addEventListener('error', setError) | ||
|
|
||
| return () => { | ||
| clearTimeout(openTimer) |
There was a problem hiding this comment.
This sort of React is my kryptonite @david-crespo please review
test/e2e/instance-serial.e2e.ts
Outdated
| await expect(xterm.getByText('Wake up Neo...').first()).toBeVisible() | ||
| // MSW streams a boot log. Wait for the login prompt which comes at the end. | ||
| await expect(xterm.getByText('oxide-instance login:').first()).toBeVisible({ | ||
| timeout: 15000, |
There was a problem hiding this comment.
Feels bad to waste this much time on the test?
There was a problem hiding this comment.
Fine in theory, but it did flake in CI, so I'll see if we can avoid it.
|
Light mode contrast seems good to me. The colors are not very readable as colors but I can live with it for the release. |
|
Unfortunately this doesn't test well in local dev pointed at dogfood, so I will merge this and test it by deploying to dogfood. |
david-crespo
left a comment
david-crespo
left a comment
There was a problem hiding this comment.
Looks good. MutationObserver is good. Got rid of the delay on open state because in production there's a delay on connection that's hard to simulate in MSW.
oxidecomputer/console@41d066c...ac30d2d * [ac30d2d8](oxidecomputer/console@ac30d2d8) oxidecomputer/console#3127 * [b43b9954](oxidecomputer/console@b43b9954) oxidecomputer/console#3126 * [cb1286cb](oxidecomputer/console@cb1286cb) oxidecomputer/console#3130 * [0f606e4c](oxidecomputer/console@0f606e4c) oxidecomputer/console#3125 * [cdc7200e](oxidecomputer/console@cdc7200e) oxidecomputer/console#3122
|
Worked well on dogfood. |
oxidecomputer/console@41d066c...ac30d2d * [ac30d2d8](oxidecomputer/console@ac30d2d8) oxidecomputer/console#3127 * [b43b9954](oxidecomputer/console@b43b9954) oxidecomputer/console#3126 * [cb1286cb](oxidecomputer/console@cb1286cb) oxidecomputer/console#3130 * [0f606e4c](oxidecomputer/console@0f606e4c) oxidecomputer/console#3125 * [cdc7200e](oxidecomputer/console@cdc7200e) oxidecomputer/console#3122
2 participants
Colours in light mode aren't super saturated. Can possibly revisit and add different ones per mode but doesn't seem super important. I'd have to review other peoples light themes to see how they use colour but keep the contrast high.
#3087